ustp, branch master

netif_utils: close the port file on a read error

2026-10-16T09:34:12Z

get_port_file() returned without closing the descriptor when read() failed. Go through the common exit, which closes it; res is still -1 there. Signed-off-by: Felix Fietkau

netif_utils: size sysfs path buffers for the longest interface name

2026-09-26T03:53:32Z

get_port_file() formatted /sys/class/net//brport/ into a buffer of 32 + IFNAMSIZ bytes. A bridge port with a 15 character name, such as the WDS station interface phy0.0-ap0.sta1, and the file bpdu_filter need 50 bytes, so the fortified sprintf() aborted ustpd with SIGTRAP. The port stays in the bridge, so every respawn aborted again until procd gave up, leaving all bridge ports in the blocking state. Use PATH_MAX buffers and snprintf() with a truncation check in get_port_file() and is_bridge(). Signed-off-by: Felix Fietkau

mstp: use default Hello Time in recordTimes

2026-05-27T11:26:50Z

802.1Q-2011 says recordTimes should set Hello Time to the default. Follow that instead of preserving the local configured Hello Time. This fixes received information aging when the local bridge uses a shorter Hello Time than its neighbor. With OpenWrt's hello_time=1 and a Huawei S6720 sending RSTP BPDUs every 2 seconds, rcvdInfoWhile was set to 3 seconds. With normal scheduling jitter, the superior information could expire before the next BPDU, causing ustp to briefly elect itself root and send a self-root BPDU. On a realtek Edgecore ECS4100-12PH, this caused repeated MSTP PACKET_ERR_COMPLIAN errors on the Huawei side, together with brief forwarding -> discarding -> forwarding state changes: May 13 2026 16:31:22+03:00 DST cs0 %%01MSTP/3/PACKET_ERR_COMPLIAN(l)[47259]:The port compliance protocol type of the packet received by MSTP from the port XGigabitEthernet0/0/3,(InsId:0,RcvInt:0,SrcMAC:fa8e-a111-a57f,RootId:32768.f88e-a111-a574,ExCost:0,BdgId:32768.f88e-a111-a574,PortId:128.10,RegRootId:0.0000-0000-0000,InCost:0) is invalid. May 13 2026 16:31:22+03:00 DST cs0 %%01MSTP/4/SET_PORT_DISCARDING(l)[47260]:In MSTP process 0 instance 0, MSTP set port XGigabitEthernet0/0/3 state as discarding. May 13 2026 16:31:22+03:00 DST cs0 %%01MSTP/4/SET_PORT_FORWARDING(l)[47261]:In MSTP process 0 instance 0, MSTP set port XGigabitEthernet0/0/3 state as forwarding. May 13 2026 16:31:46+03:00 DST cs0 %%01MSTP/3/PACKET_ERR_COMPLIAN(l)[47262]:The port compliance protocol type of the packet received by MSTP from the port XGigabitEthernet0/0/3,(InsId:0,RcvInt:0,SrcMAC:fa8e-a111-a57f,RootId:32768.f88e-a111-a574,ExCost:0,BdgId:32768.f88e-a111-a574,PortId:128.10,RegRootId:0.0000-0000-0000,InCost:0) is invalid. May 13 2026 16:31:46+03:00 DST cs0 %%01MSTP/4/SET_PORT_DISCARDING(l)[47263]:In MSTP process 0 instance 0, MSTP set port XGigabitEthernet0/0/3 state as discarding. May 13 2026 16:31:46+03:00 DST cs0 %%01MSTP/4/SET_PORT_FORWARDING(l)[47264]:In MSTP process 0 instance 0, MSTP set port XGigabitEthernet0/0/3 state as forwarding. There were 2396 errors between 2026-05-01 and 2026-05-19 10:00 with one OpenWrt realtek switch running STP. After deploying this fix on two Edgecore ECS4100-12PH switches, both running OpenWrt + ustp and connected to the same Huawei, there were zero errors for 8 days. Fixes: fd93aaef9ba9 ("Initial import") Signed-off-by: Stijn Tintel

mstp: add default Hello Time constant

2026-05-27T11:21:34Z

The default Hello Time is used when initializing a bridge. Add a constant for it instead of hard-coding the value. This will be reused in the next commit to follow the 802.1Q-2011 recordTimes behavior. Signed-off-by: Stijn Tintel

netif_utils: correctly close fd on read error

2023-05-29T15:07:54Z

Fix Coverity Scan CID 1521069 reporting leaking fd on read error. Refactor the read error handling and correctly close fd on read error. Signed-off-by: Christian Marangi

build: use pthread cflags/ldflags

2021-09-21T17:41:11Z

Fixes build on glibc Signed-off-by: Felix Fietkau

libnetlink: turn rtnetlink error answers into debug msgs

2021-08-27T10:36:45Z

They should not be logged by default Signed-off-by: Felix Fietkau

bridge: check port bpdu filter status and apply it to the config

2021-08-27T10:19:30Z

Signed-off-by: Felix Fietkau

libnetlink: fix netlink buffer space handling

2021-08-25T11:29:47Z

Significantly increaese buffer size in order to avoid missing events Do not stop polling socket after running out of buffer space Signed-off-by: Felix Fietkau

brmon: continue polling the socket after an error occured

2021-08-25T11:29:16Z

Fixes a corner case with edge-trigger epoll Signed-off-by: Felix Fietkau