odhcpd/src/ndp.c, branch master

ndp: correctness fix for BPF filter

2025-11-23T19:05:35Z

Note that AF_PACKET sockets start receiving packets as soon as they are created. Thus, a packet can arrive between the creation of the socket and the time the real filter is installed. Fix this using the same technique as used in libpcap, i.e. by installing a drop-all filter, removing any packets from the socket, then installing the real filter later (an atomic operation which replaces the drop filter). Signed-off-by: David Härdeman Link: https://github.com/openwrt/odhcpd/pull/319 Signed-off-by: Álvaro Fernández Rojas

src: improve attributes

2025-11-17T07:24:50Z

- Properly guard odhcp6c.h attributes with `#ifndef` to avoid redefining them when including external headers. - Also convert the remaining __attribute__ usages to the custom declarations. - Consolidate custom declarations with _o_ prefix. Signed-off-by: Álvaro Fernández Rojas Link: https://github.com/openwrt/odhcpd/pull/307

src: consolidate and improve fallthrough

2025-11-17T07:24:34Z

- Enable fallthrough warnings. - Use fallthrough attribute instead of comments. - Drop unneeded fallthroughs (no code between two case statements). Signed-off-by: Álvaro Fernández Rojas Link: https://github.com/openwrt/odhcpd/pull/307

src: fix whitespace issues

2025-11-11T11:46:15Z

- Remove double whitespaces. - Convert whitespace alignments to tabs. - Fix code comments using whitespaces. Signed-off-by: Álvaro Fernández Rojas

odhcpd: add log helpers

2025-10-18T15:40:09Z

These a just a bit more succinct than their syslog equivalents. Also, this lays the ground for the next patch. Signed-off-by: David Härdeman Link: https://github.com/openwrt/odhcpd/pull/273 Signed-off-by: Álvaro Fernández Rojas

ndp: fix macOS IPv6 compatibility by using link-local source addresses

2025-10-09T06:43:26Z

macOS ignores NDP packets that don't originate from link-local addresses, causing IPv6 connectivity issues with odhcpd. This change ensures NDP packets (Neighbor Advertisements and ICMP Echo Requests) are sent using link-local source addresses for RFC 4861 compliance. Changes: * Add ndp_from_link_local configuration flag (defaults to true) * Add odhcpd_send_with_src() to allow explicit source address control * Add odhcpd_try_send_with_src() helper to eliminate code duplication * Add odhcpd_get_interface_linklocal_addr() with caching for performance * Update send_na() and ping6() to use link-local source addresses when enabled * Add RFC 4861, §4.2 comments explaining the mandated behavior * Maintain backward compatibility with fallback behavior Fixes: openwrt/openwrt#7561 #202 Signed-off-by: Stephen Groat Link: https://github.com/openwrt/odhcpd/pull/242 Signed-off-by: Álvaro Fernández Rojas

ndp: Allow NS loopback for master iface

2025-10-03T05:37:28Z

This commit modifies handle_solicit() in ndp.c to correct IPv6 relay handling of Neighbor Solicitation (NS) requests when no upstream solicitation is received. Background: In IPv6 relay mode, odhcpd discovers local devices only upon receiving upstream NS packets. If no upstream NS arrives (e.g. because the upstream router’s neighbor cache is still valid or no solicitation was ever sent), OpenWrt may attempt neighbor resolution via the master (WAN) interface instead of the LAN, leaving local devices undiscoverable and breaking connectivity. - When an NS packet is sent by the host's master interface, do not immediately return; instead continue searching slave interfaces for the target neighbor. - When odhcpd responds to NS packets, add a check to prevent replying to NS packets that were sent by the host itself. Signed-off-by: Haoyi Ci cihaoyi@outlook.com Link: https://github.com/openwrt/odhcpd/pull/240 Signed-off-by: Álvaro Fernández Rojas

treewide: spell-fixes and new comments for extra clarification

2024-05-07T22:06:41Z

Fix some spell mistake and add new comments for extra clatification. Signed-off-by: Paul Donald Reviewed-by: Daniel Golle [ improve commit title ] Signed-off-by: Christian Marangi

treewide: optimize syslog priority values

2019-12-15T19:44:16Z

Signed-off-by: Hans Dedecker

ndp: fix endian issue

2019-10-13T18:39:33Z

Fix endian issue introduced in commit 91a28e4 by using ND_NA_FLAG_SOLICITED defined in netinet/icmp6.h Signed-off-by: Hans Dedecker