odhcpd/src/config.c, branch master

all: remove dead code

2025-12-18T17:05:47Z

follow-up to 4df45c8c37227b67319ca39ee4eb2d21966ee693 These are not used anywhere Signed-off-by: Paul Donald Link: https://github.com/openwrt/odhcpd/pull/361 Signed-off-by: Álvaro Fernández Rojas

config: add default value for dhcpv6_pd_min_len

2025-12-14T19:35:08Z

Right now, dhcpv6_pd_min_len is zero, meaning any request would be accepted (as long as it fits what we have available). That means that with a /56 (a common residential scenario), a downstream router can request a /57 and gobble up 1/2 of the available address space. Even a default dhcpv6_pd_min_len value of 60 means that we'd support 15 PDs in total. So let's err on the side of caution and set /62 as the default, people who want larger allocations can easily override the default. Signed-off-by: David Härdeman Link: https://github.com/openwrt/odhcpd/pull/357 Signed-off-by: Álvaro Fernández Rojas

config: allow minimum PD len up to 64

2025-12-14T19:34:45Z

The current limit of [1,62] doesn't really seem to be justified. With things like RFC9762 (DHCPv6-PD preferred), it isn't unlikely that we'll see more DHCPv6-PD requests in the future, and not just from actual routers. The smallest realistic PD that can be allocated is a /64, so make that the minimum. Also, fix a bug in the logic (note that the PD_MIN_LEN_MAX actually isn't enforced). Closes: #352 Signed-off-by: David Härdeman Link: https://github.com/openwrt/odhcpd/pull/357 Signed-off-by: Álvaro Fernández Rojas

statefiles: fix stale pio handling for !ubus

2025-12-09T15:38:32Z

Currently, config.c:odhcpd_reload() will call: set_config() // the piodir is set here set_interface() config_parse_interface() statefiles_read_prefix_information() statefiles_setup_dirfd() ubus_apply_network() config_parse_interface() statefiles_read_prefix_information() This works when ubus is enabled, because of the extra call to ubus_apply_network() which will read the pio file after the dirfd has been set up. However, it won't work when ubus isn't enabled since it'll turn ubus_apply_network() into a noop. Fix this by moving the statefiles_setup_dirfd() calls into set_config(), i.e. setup the dirfds as soon as the relevant cfg options have been read. Signed-off-by: David Härdeman Link: https://github.com/openwrt/odhcpd/pull/333 Signed-off-by: Álvaro Fernández Rojas

odhcpd: rename piofolder to piodir

2025-12-09T15:38:25Z

A "folder" is a Windows concept, rename the cfg option from "piofolder" to "piodir", which will also make it more consistent with other cfg options. Signed-off-by: David Härdeman Link: https://github.com/openwrt/odhcpd/pull/333 Signed-off-by: Álvaro Fernández Rojas

statefiles: rename prefix information functions

2025-12-09T15:33:50Z

This makes it clearer that the functions are in statefiles.c. Signed-off-by: David Härdeman Link: https://github.com/openwrt/odhcpd/pull/333 Signed-off-by: Álvaro Fernández Rojas

config: move pio json handling to statefiles.c

2025-12-09T15:29:12Z

The prefix information files are also examples of statefiles, and there are some things which can be shared between e.g. the state file logic and the pio file logic (like the conversion from MONOTIME to time_t and back, and also the use of tmp files). That's for later patches though, this just moves the code without any code changes to make subsequent patches clearer. Signed-off-by: David Härdeman Link: https://github.com/openwrt/odhcpd/pull/333 Signed-off-by: Álvaro Fernández Rojas

statefiles: add a dirfd helper function

2025-12-09T15:29:08Z

The same logic was repeated three times in config.c, move it to a single function in statefiles.c. Signed-off-by: David Härdeman Link: https://github.com/openwrt/odhcpd/pull/333 Signed-off-by: Álvaro Fernández Rojas

odhcpd: remove OAF_BROKEN_HOSTNAME

2025-11-30T16:00:14Z

A bool is quite a bit more ergonomic (as the diff for this commit shows). Signed-off-by: David Härdeman Link: https://github.com/openwrt/odhcpd/pull/331 Signed-off-by: Álvaro Fernández Rojas

src: fix shadowed local variables

2025-11-28T07:32:10Z

Fix shadowed local variables and enable warning to prevent more shadowed variables in the future. Signed-off-by: Álvaro Fernández Rojas